Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix second chance #13

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Fix second chance #13

merged 5 commits into from
Nov 7, 2024

Conversation

gares
Copy link
Owner

@gares gares commented Nov 6, 2024

No description provided.

@gares
Copy link
Owner Author

gares commented Nov 6, 2024

More tests revealed that #10 was incomplete (the wait_for one, fixed only the check_for).
Also the filtering for higher priority was skewed.

Now if 2 system events compete, the one with high priority gets a chance to terminate even if the other one needs less rounds (eg a simpler event vs an httpcle one)

gares added 2 commits November 7, 2024 10:47
# Conflicts:
#	test/fairness_prio.ml
@gares
Copy link
Owner Author

gares commented Nov 7, 2024

This implements the other optimization I mentioned in #10 , namely to eagerly read more bytes for the HTTP cle header.
It is 3.4 times faster in the micro bench.

@gares gares merged commit b403e0c into main Nov 7, 2024
3 checks passed
@gares gares deleted the fix-second-chance branch November 7, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant