Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu15 and systemd support #37

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

justin8
Copy link

@justin8 justin8 commented Jun 14, 2015

Added support for systemd systems with pip installs (Fedora 14+, RHEL 7+, Debian 8+, Ubuntu 15.04+ & Archlinux)

Added rspec tests for the service files.

Fixed collector paths for ubuntu pip installs (they go to /usr/local/share instead of /usr/share like most other OSes).

Fixed spec tests that had osfamily => 'Ubuntu'. Should've been osfamily => 'Debian', operatingsystem => 'Ubuntu' like on real systems.

@purplexa
Copy link
Contributor

I don't see why any of this is necessary, personally, except maybe the spec test fixes for Ubuntu.

@justin8
Copy link
Author

justin8 commented Nov 12, 2015

It adds support for pure systemd implementations like Arch Linux as well.

@purplexa
Copy link
Contributor

If all you need is the unit file, why not try to get that straight into upstream?

@justin8
Copy link
Author

justin8 commented Nov 12, 2015

I wrote it a while ago, and don't actually use diamond any more. Mostly because the upstream was too slow to do anything.

Also that would be one of the 9 files changed in the PR.

@jtriley
Copy link

jtriley commented Jun 23, 2016

Turns out the reason the service file is missing is because pip by default installs using binaries/wheels. The diamond wheel was built on ubuntu so when setup.py was executed it only evaluated the 'ubuntu' case statement in setup.py for service files. You can disable this using:

$ pip install --no-binary :all: diamond

which will do a source install that invokes setup.py, correctly identifies the current system, and installs the service file accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants