-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu15 and systemd support #37
base: master
Are you sure you want to change the base?
Conversation
…ethr-diamond into ubuntu15-and-systemd-support
… and /var/log/diamond/diamond.log in all diamond versions
I don't see why any of this is necessary, personally, except maybe the spec test fixes for Ubuntu. |
It adds support for pure systemd implementations like Arch Linux as well. |
If all you need is the unit file, why not try to get that straight into upstream? |
I wrote it a while ago, and don't actually use diamond any more. Mostly because the upstream was too slow to do anything. Also that would be one of the 9 files changed in the PR. |
Turns out the reason the service file is missing is because pip by default installs using binaries/wheels. The diamond wheel was built on ubuntu so when setup.py was executed it only evaluated the 'ubuntu' case statement in setup.py for service files. You can disable this using:
which will do a source install that invokes setup.py, correctly identifies the current system, and installs the service file accordingly. |
Added support for systemd systems with pip installs (Fedora 14+, RHEL 7+, Debian 8+, Ubuntu 15.04+ & Archlinux)
Added rspec tests for the service files.
Fixed collector paths for ubuntu pip installs (they go to /usr/local/share instead of /usr/share like most other OSes).
Fixed spec tests that had osfamily => 'Ubuntu'. Should've been osfamily => 'Debian', operatingsystem => 'Ubuntu' like on real systems.