Require system pkgs before installing collector via pip #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squash merge of justin8/ubuntu15-and-systemd-support on top of fasrc/use-params-class plus patch to use camptocamp/systemd puppet module.
defaults to false
Installs custom collectors by cloning a repo into collectors directory.
causes duplicate resources in fasrc repo given that we manage python packages in a global package list and python puppet module tries to install those same packages when it gets included. just using the defined type without an include works because it avoids the install phase in the python puppet module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip pkgs may have additional dependencies that are only satisfied via system packages, so add a 'require' for those to create the relationship.