-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Properties for SocialProfile #23
Comments
Hey @timReynolds, yeah the above is how I would have always done it myself. When looking into the social profile I thought it might be a safer bet to go with how Google is now recommending it. I think adding Logo and Local Business as new data types would be the best way forward. If adding these they would need to be covered by end to end tests in For Local Business, I would be happy with a minimal version to cover your use case. Maybe something like:
I can then extend it to add opening hours and actions etc. once published with this minimal needed. |
Sounds good, I’ll look into this over the next few days |
Implement logo as found in the [google structure data documentation](https://developers.google.com/search/docs/data-types/logo) Related to #23
This adds support for[ basic local business](https://developers.google.com/search/docs/data-types/local-business) properties as outlined in the readme. By default the type will be LocalBusiness but users can provide any valid sub-type as per the documentation. Images code was taken from product but not turned into a generic helper. This felt like it could be reused but leaving them separate allowed for better isolation. Happy to change this and move buildImages to a common builders file with tests. Additional changes to reorder imports/exports alphabetically and add the missing product link in the readme are included in the same commit. Fixes #23
Although not well documented the markup for social profile is normally used with other related properties like description, telephone, address and logo (org only) show in the valid JsonLd below;
I'm happy to add support for these additional properties to social profile or I could as new structured data types as Logo and Local Business which is how the google documentation refers to them, although technically they're supported in the same block as social information.
@garmeeh I'm planning to do this work as I need it either locally or as a PR if you can provide some guidance on how you'd prefer this done.
If any of this isn't clear please let me know.
The text was updated successfully, but these errors were encountered: