Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lambdaInvoke permissions for SNS Events #91

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

tvandewalle
Copy link

SNS events need to be given the lambdaInvoke permission so that they can
call the lambda function. When the event is disabled/removed the permission
is also removed.

Fixes #76.

SNS events need to be given the lambdaInvoke permission so that they can
call the lambda function.

Fixes garnaat#76.
@josegonzalez josegonzalez merged commit d7a4fd8 into garnaat:develop Sep 12, 2016
@olabhrad
Copy link

There is a an issue here. The add and remove functions are using the following:

StatementId=function.name+'_'+self._context.environment

This means that you can only add one SNS event source. On the second attempt you will get an error as you are using the same statement ID:

kappa.event_source.sns - DEBUG - Permission already exists - Continuing

Instead of using the function name, you could use the event source name which should be unique e.g.

StatementId=self.arn.split(":")[-1]

@olabhrad
Copy link

PR to fix above issue: #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants