Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change font styles to work well without LaTeX #94

Merged
merged 3 commits into from
May 30, 2023
Merged

Change font styles to work well without LaTeX #94

merged 3 commits into from
May 30, 2023

Conversation

JBorrow
Copy link
Contributor

@JBorrow JBorrow commented May 23, 2023

Fixes #93

@JBorrow
Copy link
Contributor Author

JBorrow commented May 23, 2023

Ok, that's ready to go now.

I will leave it up to you to decide whether usetex: True should be the default. With these changes, it's actually not really needed, but that would be a breaking change.

@JBorrow
Copy link
Contributor Author

JBorrow commented May 23, 2023

(Also fixes #25, if you use ieee too).

@echedey-ls
Copy link
Collaborator

Thank you very much!

I'd like to make it as easy as possible for users, so I'm all for setting usetex: False in the science style, deleting the no-latex style and creating a latex one.
@garrettj403 what do you think about it?

@echedey-ls
Copy link
Collaborator

Having a second thought on this, we can leave usetex out of science.mplstyle and turn it on just in the language styles and latex-sans.mplstyle.
I will test this PR and merge once I have concluded this is the best approach.

Thanks again @JBorrow !

@echedey-ls echedey-ls merged commit 337e87a into garrettj403:master May 30, 2023
@echedey-ls
Copy link
Collaborator

I will think about the usetex switch for future releases, and leave this as it is for now.
Well done JBorrow.

echedey-ls added a commit to echedey-ls/SciencePlots that referenced this pull request Nov 25, 2023
@echedey-ls
Revert "Change font styles to work well without LaTeX (garrettj403#94)"
95b853f 
This reverts commit 337e87a.
echedey-ls added a commit that referenced this pull request Nov 25, 2023
@echedey-ls @JBorrow
Re-fix #30 (#106)
26eb00a 
* Revert "Change font styles to work well without LaTeX  (#94)"

This reverts commit 337e87a.

* Re-refix #30 in accordance to #93

Still need to ensure desired behaviour.

Co-Authored-By: Josh Borrow <josh@joshborrow.com>

---------

Co-authored-by: Josh Borrow <josh@joshborrow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Rendering bug with no-latex
2 participants
@JBorrow @echedey-ls