Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import process from "node:node:process"; #110

Open
dancrumb opened this issue Jun 15, 2023 · 0 comments
Open

import process from "node:node:process"; #110

dancrumb opened this issue Jun 15, 2023 · 0 comments

Comments

@dancrumb
Copy link
Collaborator

So, it looks like there was an unexpected interaction between the new process handling code and the denoifyImportExportStatement code.

I denoified some code and got this line of code:

import process from "node:node:process";

I think part of the issue is that the test cases are mocking denoifyImportExportStatement, so this type of error slipped through.
dancrumb added a commit to dancrumb/denoify that referenced this issue Jun 18, 2023
@dancrumb
feat: handle node builtings better
07e30ad 
This change is designed to handle the node builtins more effectively, since they were moved to `node:xxx`;

Fixes garronej#110
@dancrumb dancrumb mentioned this issue Jun 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: handle node builtins better dancrumb/denoify
1 participant
@dancrumb