DateTime filter: include nanoseconds, when nonzero #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could show this always, but it would be a change and it seems a little friendlier to omit zero nanoseconds, since so many duration will be 0ns, and it won't be interesting. On the other hand, ignoring some differences isn't a very good way to present the data!
rjbs
force-pushed
the
datetime-nanosecond
branch
from
6838548 to
4646ab9
Compare
|
I have fixed CI failures, which happened because I missed a (This suggests to me that we should be making sure that all optional prereqs are installed on CI!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could show this always, but it would be a change and it seems a little friendlier to omit zero nanoseconds, since so many duration will be 0ns, and it won't be interesting.
On the other hand, ignoring some differences isn't a very good way to present the data!