Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build before and after compile commands extraction #118

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

cpsauer
Copy link
Contributor

@cpsauer cpsauer commented Dec 14, 2023

Hey guys! Hedron Compile Commands Extractor author here. I saw your #111, @garymm, while catching up on hedronvision/bazel-compile-commands-extractor#140. If you're going to run a build after, it might well be worth running it before, after. That way the extractor is more likely to hit a fresh header cache from the build and run faster :)

@cpsauer
Copy link
Contributor Author

cpsauer commented Dec 14, 2023

Though note that we'll likely have the issue underlying #111 solved soon, so you soon won't need the build after
bazelbuild/bazel#20540

@garymm garymm enabled auto-merge (squash) December 14, 2023 16:47
Copy link
Owner

@garymm garymm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2661e14) 97.54% compared to head (02d054d) 97.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          15       15           
  Lines         408      408           
=======================================
  Hits          398      398           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garymm garymm merged commit b57b4d1 into garymm:master Dec 14, 2023
15 checks passed
@cpsauer
Copy link
Contributor Author

cpsauer commented Jan 20, 2024

Underlying issue fixed in the bazel mainline! Should be released as part of Bazel 7.1 and the next rolling release, so you can remove the after-build (and the build before if you want) then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants