Use minimal data URL for loading fetch() #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Okay, the current example only works because it fails on the request object creation and will not execute the fetch() at all. Will watch for other solutions. |
|
Using now a minimal valid data URL. That URL is valid and will not throw anymore. It will not involve any network activity, which is also good I think. |
mwenko
changed the title
|
@djMax Could you please have a review on this one? |
djMax
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue (getsentry/sentry-javascript#12343) that should have been resolved by this PR #15 did not work.
Providing a minimal data URL to Fetch() will not cause an unhandled promise exception and will result in a clean startup. The minimal data URL will also ensure that there is no network activity for the fetch() call, which will not make it depended on any connectivity requirements.
I started my project with Sentry (8.19) with the debugger enabled and it worked.
cc @timfish @djMax