Merge branch 'develop' of github.com:gasserandreas/rekognition into f…

…eat/#110/github-actions

.eslintrc

@@ -1,22 +1,47 @@
 {
-  "extends": "react-app",
+  "extends": ["airbnb"],
+  "globals": {
+    "window": true,
+    "fetch": true,
+    "document": true
+  },
   "plugins": [
-    "react-hooks"
+    "react-hooks",
+    "babel"
   ],
+  "parser": "babel-eslint",
   "rules": {
     "react/jsx-no-bind": 0,
     "react/require-default-props": 1,
     "react/no-danger": 1,
-    "max-len": [1, 120, 2],
     "class-methods-use-this": 0,
     "jsx-a11y/anchor-is-valid": 0,
     "react-hooks/rules-of-hooks": "error",
-    "react-hooks/exhaustive-deps": "warn"
+    "react-hooks/exhaustive-deps": "warn",
+    "max-len": [
+      "error",
+      {
+        "code": 120
+      }
+    ],
+    "no-underscore-dangle": "off",
+    "react/destructuring-assignment": "off",
+    "eslint/no-plus-plus": "off"
   },
   "overrides": [
     {
       "files": ["**/__tests__/**.js", "**/*.test.js", "**/src/setupTests.js"],
-      "env": { "jest": true }
+      "env": { "jest": true },
+      "rules": {
+        "react/jsx-filename-extension": 0
+      }
+    },
+    {
+      "files": ["**/*.stories.js", ".storybook/**/*"],
+      "rules": {
+        "import/no-extraneous-dependencies": 0,
+        "react/jsx-filename-extension": 0
+      }
     }
   ]
 }

.vscode/launch.json

@@ -10,6 +10,22 @@
       "name": "Launch Chrome against localhost",
       "url": "https://localhost:3000/#/",
       "webRoot": "${workspaceFolder}/src",
+    },
+    {
+      "name": "Debug CRA Tests",
+      "type": "node",
+      "request": "launch",
+      "runtimeExecutable": "${workspaceRoot}/node_modules/.bin/react-scripts",
+      "args": [
+        "test",
+        "--runInBand",
+        "--no-cache",
+        // "--no-watch",
+      ],
+      "cwd": "${workspaceRoot}",
+      "protocol": "inspector",
+      "console": "integratedTerminal",
+      "internalConsoleOptions": "neverOpen"
     }
   ]
 }

CHANGELOG.md

@@ -1,3 +1,47 @@
+# [1.2.0](https://github.com/gasserandreas/rekognition/compare/v1.1.0...v1.2.0) (2019-05-08)
+
+
+### Bug Fixes
+
+* **#104:** fixed package issues with storybook and improve test coverage script ([fe6525e](https://github.com/gasserandreas/rekognition/commit/fe6525e))
+* **#104:** improved package.json file and coverage collection ([596a36e](https://github.com/gasserandreas/rekognition/commit/596a36e)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** refactored ui components ([3c45875](https://github.com/gasserandreas/rekognition/commit/3c45875)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** removed code smells ([0d32e5b](https://github.com/gasserandreas/rekognition/commit/0d32e5b)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** removed stories files from test coverage report ([ba2e5f3](https://github.com/gasserandreas/rekognition/commit/ba2e5f3)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** removed unused code ([e8f0212](https://github.com/gasserandreas/rekognition/commit/e8f0212)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#105:** updated npm testing packages ([e2433aa](https://github.com/gasserandreas/rekognition/commit/e2433aa)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#107:** fixed failing test cases and removed prop type warnings ([3945c47](https://github.com/gasserandreas/rekognition/commit/3945c47))
+
+
+### Features
+
+* **#104:** added / improved test cases for main redux code ([39cd305](https://github.com/gasserandreas/rekognition/commit/39cd305)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** added more test cases for base app components ([5223f0f](https://github.com/gasserandreas/rekognition/commit/5223f0f)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** added test cases for faces and labels redux subtree ([71980b1](https://github.com/gasserandreas/rekognition/commit/71980b1)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** added test cases for images redux sub tree and selectors ([e3817b4](https://github.com/gasserandreas/rekognition/commit/e3817b4)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** added test cases for images util ([17d7153](https://github.com/gasserandreas/rekognition/commit/17d7153)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** added test cases for reactors ([1108e90](https://github.com/gasserandreas/rekognition/commit/1108e90)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** added test cases for user redux tree ([c132141](https://github.com/gasserandreas/rekognition/commit/c132141)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** finished App component test cases ([9d500bb](https://github.com/gasserandreas/rekognition/commit/9d500bb)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** finished selector test ([1ab48ae](https://github.com/gasserandreas/rekognition/commit/1ab48ae)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** improved test cases for redux store and GraphApi ([5d9d0e4](https://github.com/gasserandreas/rekognition/commit/5d9d0e4)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#104:** wrote test cases for application redux sub tree ([a78ff6a](https://github.com/gasserandreas/rekognition/commit/a78ff6a)), closes [#104](https://github.com/gasserandreas/rekognition/issues/104)
+* **#105:** added test cases for AddImageButton ([33a8c97](https://github.com/gasserandreas/rekognition/commit/33a8c97)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** added test cases for auth hooks ([6705d5b](https://github.com/gasserandreas/rekognition/commit/6705d5b)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** added test cases for details Attribute component and container ([01932a5](https://github.com/gasserandreas/rekognition/commit/01932a5)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** added test cases for ImageList comp ([4010cef](https://github.com/gasserandreas/rekognition/commit/4010cef)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** added test cases for Label, Labels and Faces ([b002cd1](https://github.com/gasserandreas/rekognition/commit/b002cd1)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** added test cases for ListView and Container ([16ca23c](https://github.com/gasserandreas/rekognition/commit/16ca23c)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** added test cases for Login app ([dc2e6a7](https://github.com/gasserandreas/rekognition/commit/dc2e6a7)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** added test cases for user sub app ([f1d4495](https://github.com/gasserandreas/rekognition/commit/f1d4495)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** added tests for auth sub path ([81c883d](https://github.com/gasserandreas/rekognition/commit/81c883d)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** finished test cases for image details ([d598f2d](https://github.com/gasserandreas/rekognition/commit/d598f2d)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** finished test implementation for Image component ([e24c9fa](https://github.com/gasserandreas/rekognition/commit/e24c9fa)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#105:** started with auth login test cases ([d7701ca](https://github.com/gasserandreas/rekognition/commit/d7701ca)), closes [#105](https://github.com/gasserandreas/rekognition/issues/105)
+* **#107:** added maintenance script tasks to buildspec ([0644341](https://github.com/gasserandreas/rekognition/commit/0644341)), closes [#107](https://github.com/gasserandreas/rekognition/issues/107)
+* **#107:** fixed all EsLint issues ([b51385f](https://github.com/gasserandreas/rekognition/commit/b51385f))
+* **#107:** improved script command and added coverage treshold ([3b79027](https://github.com/gasserandreas/rekognition/commit/3b79027)), closes [#107](https://github.com/gasserandreas/rekognition/issues/107)
+
 # [1.1.0](https://github.com/gasserandreas/rekognition/compare/v1.0.0...v1.1.0) (2019-04-01)
 
 

buildspec.yml

@@ -19,8 +19,12 @@ phases:
       - aws s3 cp $S3_UTILS_BUCKET$ENV_VAR ./
   build:
     commands:
+      - echo "Start linting"
+      - npm run lint
       - echo "Start test"
-      - CI=true npm test 
+      - CI=true npm test
+      - echo "Start coverage"
+      - CI=true npm run test:coverage
       - echo "Run Semantic Release"
       - GH_TOKEN="$GH_ACCESS_TOKEN" npx semantic-release
       - echo "Build started on $CODEBUILD_START_TIME"