group and VPN creation API should return created object response

gate-sso · Jan 28, 2019 · a4a032f · a4a032f
1 parent b119e45
commit a4a032f
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 4 deletions.
diff --git a/app/controllers/api/v1/groups_controller.rb b/app/controllers/api/v1/groups_controller.rb
@@ -3,7 +3,10 @@ def create
     if current_user.admin?
       @group = Group.new(group_params)
       if @group.save
-        render json: { status: 'created' }, status: :ok
+        render json: { 
+          id: @group.id,
+          name: @group.name,
+        }, status: :ok
       else
         render json: { status: 'error' }, status: :unprocessable_entity
       end

diff --git a/app/controllers/api/v1/vpns_controller.rb b/app/controllers/api/v1/vpns_controller.rb
@@ -5,7 +5,12 @@ def create
     if current_user.admin?
       @vpn = Vpn.new(vpn_params)
       if @vpn.save
-        render json: { status: 'created' }, status: :ok
+        render json: { 
+          id: @vpn.id,
+          name: @vpn.name,
+          host_name: @vpn.host_name,
+          ip_address: @vpn.ip_address,
+        }, status: :ok
       else
         render json: { status: 'error' }, status: :unprocessable_entity
       end

diff --git a/spec/controllers/api/v1/groups_controller_spec.rb b/spec/controllers/api/v1/groups_controller_spec.rb
@@ -17,11 +17,19 @@
       context 'with valid_attributes' do
         it 'should create groups' do
           post :create,  params: {group: valid_attributes, access_token: @token}
-          expect(response.status).to eq(200)
           group = Group.where(name: valid_attributes[:name]).first
           expect(group.blank?).to eq(false)
           expect(group.name).to eq(valid_attributes[:name])
         end
+
+        it 'should return proper response' do
+          post :create,  params: {group: valid_attributes, access_token: @token}
+          expect(response.status).to eq(200)
+          group = Group.where(name: valid_attributes[:name]).first
+          obj = JSON.parse(response.body)
+          expect(obj['id']).to eq group.id
+          expect(obj['name']).to eq group.name
+        end
       end
     end
   end

diff --git a/spec/controllers/api/v1/vpns_controller_spec.rb b/spec/controllers/api/v1/vpns_controller_spec.rb
@@ -17,11 +17,21 @@
       context 'with valid_attributes' do
         it 'should create vpns' do
           post :create,  params: {vpn: valid_attributes, access_token: @token}
-          expect(response.status).to eq(200)
           vpn = Vpn.where(name: valid_attributes[:name]).first
           expect(vpn.blank?).to eq(false)
           expect(vpn.name).to eq(valid_attributes[:name])
         end
+
+        it 'should return proper response' do
+          post :create,  params: {vpn: valid_attributes, access_token: @token}
+          expect(response.status).to eq(200)
+          vpn = Vpn.where(name: valid_attributes[:name]).first
+          obj = JSON.parse(response.body)
+          expect(obj['id']).to eq vpn.id
+          expect(obj['name']).to eq vpn.name
+          expect(obj['host_name']).to eq vpn.host_name
+          expect(obj['ip_address']).to eq vpn.ip_address
+        end
       end
     end