Skip to content

Commit

Permalink
chore: Switch GitHub actions from setup-scala to setup-java
Browse files Browse the repository at this point in the history
Motivation:

See olafurpg/setup-scala#49:
- olafurpg/setup-scala is no longer considered necessary by its maintainer and will probably be archived at some point.
- Ubuntu runners now include the official SBT launcher by default.
- actions/setup-java is the official action for setting up a JDK, so we might as well use that if it"s sufficient for our purpose.

Modifications:

- Replace olafurpg/setup-scala with actions/setup-java.
- Use Zulu JDK.
  • Loading branch information
guilgaly authored and slandelle committed Dec 17, 2021
1 parent ca76973 commit d464fd2
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ jobs:

- uses: actions/checkout@v2

- name: Setup Scala
uses: olafurpg/setup-scala@v10
- name: Setup JDK
uses: actions/setup-java@v2
with:
java-version: "adopt@1.8"
distribution: 'zulu'
java-version: '8'

- name: Cache SBT
uses: actions/cache@v2
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/create_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ jobs:
fetch-depth: 0 # indicates all history for all branches and tags
token: ${{ secrets.GATLING_CI_TOKEN }} # for tag to trigger other workflows (release)

- name: Setup Scala
uses: olafurpg/setup-scala@v10
- name: Setup JDK
uses: actions/setup-java@v2
with:
java-version: "adopt@1.8"
distribution: 'zulu'
java-version: '8'

- name: Cache SBT
uses: actions/cache@v2
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@ jobs:
steps:
- uses: actions/checkout@v2

- name: Setup Scala
uses: olafurpg/setup-scala@v10
- name: Setup JDK
uses: actions/setup-java@v2
with:
java-version: "adopt@1.8"
distribution: 'zulu'
java-version: '8'

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v1
Expand Down

0 comments on commit d464fd2

Please sign in to comment.