fix(gatsby,gatsby-plugin-offline): register offline plugin when not o…

…n preview (#30984)
gatsbyjs · Apr 22, 2021 · 17f028d · 17f028d
1 parent 4f2b721
commit 17f028d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/gatsby-plugin-offline/src/gatsby-browser.js b/packages/gatsby-plugin-offline/src/gatsby-browser.js
@@ -1,4 +1,4 @@
-exports.registerServiceWorker = () => true
+exports.registerServiceWorker = () => process.env.GATSBY_IS_PREVIEW !== `true`
 
 // only cache relevant resources for this page
 const whiteListLinkRels = /^(stylesheet|preload)$/
@@ -8,6 +8,10 @@ exports.onServiceWorkerActive = ({
   getResourceURLsForPathname,
   serviceWorker,
 }) => {
+  if (process.env.GATSBY_IS_PREVIEW === `true`) {
+    return
+  }
+
   // if the SW has just updated then clear the path dependencies and don't cache
   // stuff, since we're on the old revision until we navigate to another page
   if (window.___swUpdated) {

diff --git a/packages/gatsby/cache-dir/production-app.js b/packages/gatsby/cache-dir/production-app.js
@@ -39,7 +39,7 @@ navigationInit()
 apiRunnerAsync(`onClientEntry`).then(() => {
   // Let plugins register a service worker. The plugin just needs
   // to return true.
-  if (apiRunner(`registerServiceWorker`).length > 0) {
+  if (apiRunner(`registerServiceWorker`).filter(Boolean).length > 0) {
     require(`./register-service-worker`)
   }