fix: ensure graphql key is a valid graphql key value (#4000)

* fix: ensure graphql key is a valid graphql key value * chore: update comment
gatsbyjs · Feb 14, 2018 · 9269be2 · 9269be2
1 parent 9c2a5ad
commit 9269be2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/gatsby/src/schema/__tests__/create-key.js b/packages/gatsby/src/schema/__tests__/create-key.js
@@ -10,9 +10,9 @@ describe(`createKey`, () => {
   it(`replaces invalid characters`, () => {
     ;[
       [`/hello`, `_hello`],
-      [`~/path/to/some/module`, `_-path-to-some-module`],
-      [`/*`, `_-`],
-      [`/*.js`, `_--js`],
+      [`~/path/to/some/module`, `_xpathxtoxsomexmodule`],
+      [`/*`, `_x`],
+      [`/*.js`, `_xxjs`],
     ].forEach(([input, output]) => {
       expect(createKey(input)).toBe(output)
     })

diff --git a/packages/gatsby/src/schema/create-key.js b/packages/gatsby/src/schema/create-key.js
@@ -16,9 +16,9 @@ module.exports = (key: string): string => {
 
   const replaced = key.replace(nonAlphaNumericExpr, `_`)
 
-  // key is invalid; normalize with a leading underscore and dasherize rest
+  // key is invalid; normalize with leading underscore and rest with x
   if (replaced.match(/^__/)) {
-    return replaced.replace(/_/g, (char, index) => (index === 0 ? `_` : `-`))
+    return replaced.replace(/_/g, (char, index) => (index === 0 ? `_` : `x`))
   }
 
   return replaced