Skip to content

Commit

Permalink
Revert "Enable filtering on linked nodes (#3600)"
Browse files Browse the repository at this point in the history
This reverts commit 7120e5a.
  • Loading branch information
KyleAMathews committed Jan 19, 2018
1 parent 6ac77d3 commit fdf16dd
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 36 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -482,33 +482,4 @@ describe(`GraphQL Input args`, () => {

expect(result).toMatchSnapshot()
})

it(`filters on linked fields`, async () => {
const { store, getNodes } = require(`../../redux`)
const linkedNodeType = new GraphQLObjectType({
name: `Bar`,
fields: {
id: { type: GraphQLString },
},
})
let types = [{ name: `Bar`, nodeObjectType: linkedNodeType }]

store.dispatch({
type: `CREATE_NODE`,
payload: { id: `baz`, internal: { type: `Bar` } },
})

let result = await queryResult(
[...getNodes(), { linked___NODE: `baz`, foo: `bar` }],
`
{
allNode(filter: { linked: { id: { eq: "baz" } } }) {
edges { node { linked { id } } }
}
}
`,
{ types }
)
expect(result.data.allNode.edges[0].node.linked.id).toEqual(`baz`)
})
})
7 changes: 1 addition & 6 deletions packages/gatsby/src/schema/infer-graphql-input-fields.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ const {
isEmptyObjectOrArray,
} = require(`./data-tree-utils`)

const { findLinkedNode } = require(`./infer-graphql-type`)

import type {
GraphQLInputFieldConfig,
GraphQLInputFieldConfigMap,
Expand Down Expand Up @@ -204,10 +202,7 @@ export function inferInputObjectStructureFromNodes({
if (isRoot && EXCLUDE_KEYS[key]) return

// Input arguments on linked fields aren't currently supported
if (_.includes(key, `___NODE`)) {
value = findLinkedNode(value)
;[key] = key.split(`___`)
}
if (_.includes(key, `___NODE`)) return

let field = inferGraphQLInputFields({
nodes,
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby/src/schema/infer-graphql-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ function inferFromMapping(
}
}

export function findLinkedNode(value, linkedField, path) {
function findLinkedNode(value, linkedField, path) {
let linkedNode
// If the field doesn't link to the id, use that for searching.
if (linkedField) {
Expand Down

0 comments on commit fdf16dd

Please sign in to comment.