Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-google-tagmanager): handle line breaks #11169

Merged
merged 6 commits into from
Jan 24, 2019

Conversation

stmcallister
Copy link

@stmcallister stmcallister commented Jan 20, 2019

Description

When the line breaks are present in the iframe tag, Google Search Console is not able to verify ownership of the site. This pull request removes the line breaks so that the iframe tag is all on a single line.

Related Issues

This is response to issue #11014.

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stmcallister, this LGTM 👍

If you have the time to do a follow up PR it'd be great to see a test that ensures the single line format for the iframe element. Otherwise we may unintentionally break this fix in a future update.

@DSchau DSchau changed the title fixed format of preBodyComponents to work with Google Search Console … fix(gatsby-plugin-google-tagmanager): handle line breaks Jan 24, 2019
@DSchau DSchau merged commit d974f80 into gatsbyjs:master Jan 24, 2019
@gatsbot
Copy link

gatsbot bot commented Jan 24, 2019

Holy buckets, @stmcallister — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@DSchau
Copy link
Contributor

DSchau commented Jan 24, 2019

Thanks @m-allanson for the review :)

Successfully published:
 - gatsby-plugin-google-tagmanager@2.0.8
 - gatsby@2.0.96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants