Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-google-tagmanager): handle line breaks #11169

Merged
merged 6 commits into from
Jan 24, 2019
Merged

fix(gatsby-plugin-google-tagmanager): handle line breaks #11169

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77f2ed3
fixed format of preBodyComponents to work with Google Search Console …
Jan 20, 2019
7d5f2d7
bumping gats-plugin-google-tagmanager version.
Jan 22, 2019
c800270
putting the preBody iframe all on one line
Jan 23, 2019
9961923
adjusting string to pass prettier lint requirements
Jan 23, 2019
26024b4
reverting package version to 2.0.7
Jan 23, 2019
15ae175
Add a comment
m-allanson Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions packages/gatsby-plugin-google-tagmanager/src/gatsby-ssr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,15 @@ exports.onRenderBody = (
/>,
])

// TODO: add a test to verify iframe contains no line breaks. Ref: https://github.com/gatsbyjs/gatsby/issues/11014
setPreBodyComponents([
<noscript
key="plugin-google-tagmanager"
dangerouslySetInnerHTML={{
__html: stripIndent`
<iframe
src="https://www.googletagmanager.com/ns.html?id=${
pluginOptions.id
}${environmentParamStr}"
height="0"
width="0"
style="display: none; visibility: hidden"
></iframe>`,
<iframe src="https://www.googletagmanager.com/ns.html?id=${
pluginOptions.id
}${environmentParamStr}" height="0" width="0" style="display: none; visibility: hidden"></iframe>`,
}}
/>,
])
Expand Down