Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatsby-codemods processes node_modules folder #17133

Closed
webOS101 opened this issue Aug 28, 2019 · 3 comments
Closed

gatsby-codemods processes node_modules folder #17133

webOS101 opened this issue Aug 28, 2019 · 3 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more.

Comments

@webOS101
Copy link
Contributor

Description

The directions for gatsby-codemods recommend applying the codemod to your project folder. When doing so, it attempts to process every file, regardless of location.

Suggestion: If it's not possible to restrict the codemod (best choice), suggest applying codemod to just the ./src/ directory and ./gatsby-*.js files in the REAMDE.md.

Steps to reproduce

From gatsby project directory:

jscodeshift -t node_modules/gatsby-codemods/transforms/global-graphql-calls.js .

Expected result

Only project source files are processed

Actual result

All files are processed, including ./node_modules/

Environment

 System:
    OS: macOS High Sierra 10.13.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 10.14.2 - /usr/local/bin/node
    Yarn: 1.7.0 - /usr/local/bin/yarn
    npm: 6.4.1 - /usr/local/bin/npm
  Languages:
    Python: 2.7.10 - /usr/bin/python
  Browsers:
    Chrome: 76.0.3809.100
    Firefox: 62.0.3
    Safari: 12.1.2
  npmPackages:
    gatsby: ^2.0.0 => 2.14.0
    gatsby-link: ^1.6.44 => 1.6.46
    gatsby-plugin-catch-links: ^2.1.5 => 2.1.5
    gatsby-plugin-google-analytics: ^2.1.11 => 2.1.11
    gatsby-plugin-less: ^3.0.2 => 3.0.2
    gatsby-plugin-sharp: ^2.2.18 => 2.2.18
    gatsby-plugin-typography: ^2.3.5 => 2.3.5
    gatsby-remark-autolink-headers: ^2.1.8 => 2.1.8
    gatsby-remark-copy-linked-files: ^2.1.13 => 2.1.13
    gatsby-remark-embed-youtube: 0.0.7 => 0.0.7
    gatsby-remark-images: ^3.1.19 => 3.1.19
    gatsby-remark-prismjs: ^3.3.9 => 3.3.9
    gatsby-remark-responsive-iframe: ^2.2.10 => 2.2.10
    gatsby-remark-smartypants: ^2.1.5 => 2.1.5
    gatsby-source-filesystem: ^2.1.18 => 2.1.18
    gatsby-transformer-javascript-frontmatter: ^2.1.5 => 2.1.5
    gatsby-transformer-json: ^2.2.6 => 2.2.6
    gatsby-transformer-remark: ^2.6.19 => 2.6.19
  npmGlobalPackages:
    gatsby-cli: 1.1.52
@webOS101
Copy link
Contributor Author

webOS101 commented Aug 28, 2019

Note, if you update the README instead, the example command lines for every codemod except the first refer to the ../dist/... directory, which doesn't exist. Those lines should be updated to remove that.

@gatsbot
Copy link

gatsbot bot commented Sep 18, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Sep 18, 2019
@gatsbot
Copy link

gatsbot bot commented Sep 29, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Development

No branches or pull requests

1 participant