fix(gatsby-codemods): call jscodeshift natively #38635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform-neutral call to `jscodeshift`.
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
changed the title
pieh
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform-neutral call to
jscodeshiftDescription
Currently,
gatsby-codemodsindiscriminantly calls thejscodeshiftshell script for *nix and MinGW, CYGWIN, which is shell- or OS-specific and guarantees interoperability issues such as below (in PowerShell):On
Moreover, the abovementioned shell script merely calls the Javascript source file, which is a needless indirection for NodeJS (i.e., Javascript call a shell script to call Javascript).
Result after my commit:
Documentation
Published: https://www.gatsbyjs.com/docs/reference/release-notes/migrating-from-v4-to-v5/#graphql-schema-changes-to-sort-and-aggregation-fields
Source: https://github.com/gatsbyjs/gatsby/blob/master/docs/docs/reference/release-notes/migrating-from-v4-to-v5.md#graphql-schema-changes-to-sort-and-aggregation-fields
Tests
Ran
npx gatsby-codemods@latest sort-and-aggr-graphql . --verboselocally before and after. See table:Failing❌
Passing✔
Screenshot
Screenshot
Related Issues
Fixes #7652
Addresses #16840
Addresses #17132
Addresses #17133