fix(gatsby-remark-images): adding missing plugin options (#27944 and #27998) #28035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 08447bd)
gatsbot
bot
added
the
status: triage needed
vladar
added
type: cherry
and removed
status: triage needed
vladar
changed the title
wardpeet
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting two PRs into the release branch: #27944 and #27998 The latter one requires the former and can't be cherry-picked individually. The downside is that in the release branch they will be squashed into a single commit but they both just fix plugin options of the same plugin, so I don't see a big problem here as long as we mention original commits in the message.
The alternative is to cherry-pick serially and wait for the full test suite on #27944, merge and then cherry-pick #27998 separately.
(cherry picked from commit 3675467)
(cherry picked from commit 08447bd)