Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-remark-images): adding missing plugin options #27944

Merged
merged 1 commit into from
Nov 12, 2020
Merged

fix(gatsby-remark-images): adding missing plugin options #27944

merged 1 commit into from
Nov 12, 2020

Conversation

mfrachet
Copy link
Contributor

Description

Fix the withWebp option in gatsby-remark-images option schema

Related Issues

#27437 (comment)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 10, 2020
@mfrachet mfrachet requested a review from mxstbr November 10, 2020 14:06
@mfrachet mfrachet marked this pull request as ready for review November 10, 2020 14:06
@mfrachet mfrachet requested a review from a team as a code owner November 10, 2020 14:06
@mfrachet mfrachet mentioned this pull request Nov 10, 2020
Merged
@mfrachet mfrachet requested a review from a team November 10, 2020 14:07
@mfrachet mfrachet added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 10, 2020
@frantic1048 frantic1048 mentioned this pull request Nov 10, 2020
Merged
1 task
wardpeet
wardpeet previously approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! In a follow up I would use the webp schema of gatsby-plugin-sharp, try to require it in so we don't have to duplicate it.

@mfrachet mfrachet merged commit 08447bd into gatsbyjs:master Nov 12, 2020
@mfrachet
Copy link
Contributor Author

I'm lacking context here. What do you mean by using the webp schema of sharp? I don't see it in https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-sharp/src/gatsby-node.js#L65 and it looks like it's typescript type is a Record<string, unknown> (https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-sharp/src/image-data.ts#L30)

@mfrachet mfrachet deleted the fix/options-schema-remark-images branch November 12, 2020 12:40
vladar pushed a commit that referenced this pull request Nov 13, 2020
@vladar
fix(gatsby-remark-images): adding missing plugin options (#27944)
f46e2c4 
(cherry picked from commit 08447bd)
@vladar vladar mentioned this pull request Nov 13, 2020
Merged
@vladar vladar added the hotfix label Nov 13, 2020
vladar added a commit that referenced this pull request Nov 13, 2020
@vladar
fix(gatsby-remark-images): adding missing plugin options (#27944 and #…
537bc8f 
…27998) (#28035)

* fix(gatsby-remark-images): adding missing plugin options (#27944)

(cherry picked from commit 08447bd)

* fix(gatsby-remark-images): allow showCaptions to accept array of valid strings (#27998)

(cherry picked from commit 3675467)
This was referenced Mar 13, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet left review comments

@mxstbr mxstbr Awaiting requested review from mxstbr

Assignees
No one assigned
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfrachet @wardpeet @vladar