-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-source-wordpress): HTML image regex's #29778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Feb 25, 2021
TylerBarnes
added
topic: source-wordpress
Related to Gatsby's integration with WordPress
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Feb 25, 2021
sslotsky
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very glad for the tests because I'm not about to pretend to parse all this regex 😂
vladar
pushed a commit
that referenced
this pull request
Feb 27, 2021
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit f6edccf)
vladar
pushed a commit
that referenced
this pull request
Feb 27, 2021
ascorbic
pushed a commit
that referenced
this pull request
Mar 1, 2021
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit f6edccf)
ascorbic
pushed a commit
that referenced
this pull request
Mar 1, 2021
This is released in |
This was referenced Mar 7, 2021
This was referenced Apr 15, 2024
This was referenced May 16, 2024
This was referenced Oct 13, 2024
This was referenced Oct 15, 2024
This was referenced Oct 15, 2024
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex's used to find img tags in html fields were changed to match eslint rules but that change broke the matches for certain situations (but not the ones in our tests 😢). This PR reverts those changes, matches any special character in URL's (instead of just URL-safe characters), and adds a unit test for 2 of our html regex's.