Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-wordpress): HTML image regex's #29778

Merged
merged 4 commits into from
Feb 26, 2021
Merged

fix(gatsby-source-wordpress): HTML image regex's #29778

merged 4 commits into from
Feb 26, 2021

Conversation

TylerBarnes
Copy link
Contributor

The regex's used to find img tags in html fields were changed to match eslint rules but that change broke the matches for certain situations (but not the ones in our tests 😢). This PR reverts those changes, matches any special character in URL's (instead of just URL-safe characters), and adds a unit test for 2 of our html regex's.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 25, 2021
@TylerBarnes TylerBarnes added topic: source-wordpress Related to Gatsby's integration with WordPress and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 25, 2021
@TylerBarnes TylerBarnes mentioned this pull request Feb 25, 2021
Closed
sslotsky
sslotsky approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@sslotsky sslotsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very glad for the tests because I'm not about to pretend to parse all this regex 😂

@TylerBarnes TylerBarnes merged commit f6edccf into master Feb 26, 2021
@TylerBarnes TylerBarnes deleted the fix/wp-html-image-regexes branch February 26, 2021 18:46
vladar pushed a commit that referenced this pull request Feb 27, 2021
@TylerBarnes @vladar
fix(gatsby-source-wordpress): HTML image regex's (#29778)
4149fed 
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit f6edccf)
@gatsbybot gatsbybot mentioned this pull request Feb 27, 2021
Merged
vladar pushed a commit that referenced this pull request Feb 27, 2021
@TylerBarnes
fix(gatsby-source-wordpress): HTML image regex's (#29778) (#29816)
bca7951 
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit f6edccf)

Co-authored-by: Tyler Barnes <tyler@gatsbyjs.com>
@gatsbybot gatsbybot mentioned this pull request Mar 1, 2021
Merged
ascorbic pushed a commit that referenced this pull request Mar 1, 2021
@TylerBarnes @ascorbic
fix(gatsby-source-wordpress): HTML image regex's (#29778)
f70cb1d 
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit f6edccf)
ascorbic pushed a commit that referenced this pull request Mar 1, 2021
@TylerBarnes
fix(gatsby-source-wordpress): HTML image regex's (#29778) (#29883)
c2ea9b9 
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit f6edccf)

Co-authored-by: Tyler Barnes <tyler@gatsbyjs.com>
@TylerBarnes
Copy link
Contributor Author

TylerBarnes commented Mar 1, 2021 •
edited
Loading

This is released in gatsby-source-wordpress@4.0.4

This was referenced Mar 7, 2021
Closed
Merged
Closed
Closed
@impactyogi impactyogi mentioned this pull request Mar 26, 2024
Open
This was referenced Mar 26, 2024
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request Mar 27, 2024
Open
This was referenced Mar 27, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request Mar 27, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Mar 28, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Apr 14, 2024
Open
@wizbit wizbit mentioned this pull request Apr 14, 2024
Open
@saurabharch saurabharch mentioned this pull request Apr 14, 2024
Open
@monizb monizb mentioned this pull request Apr 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Apr 15, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Apr 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
@monizb monizb mentioned this pull request Apr 29, 2024
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 16, 2024
Open
This was referenced May 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sslotsky sslotsky sslotsky approved these changes

Assignees
No one assigned
Labels
topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerBarnes @sslotsky