-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade minimatch to fix RegEx DoS security issue #10338
chore: Upgrade minimatch to fix RegEx DoS security issue #10338
Conversation
recursive-readdir
instead of recursive-readdir-synchronous
@phacks applied the Please let us know when it's ready for another set of 👀! |
e316f59
to
852e6ad
Compare
@DSchau Should be ready for a review! I created a sample repo with lots of code REPLs to test it out, it’s available here: https://github.com/phacks/gatsby-code-repl-samples I managed to implement the |
I forgot to mention that for some (as yet unknown) reason, the |
@DSchau do you think you may have some time this week to review the PR? Thanks! |
@phacks of course--will look at it today and leave any feedback! Thanks! |
68db468
to
68cb7b6
Compare
68cb7b6
to
d636495
Compare
d636495
to
cb3902c
Compare
@phacks almost there! sorry about this! |
@wardpeet No worries! It looks like the syntax you suggested isn’t available for |
Fixes #10282
TODO:
recursive-readdir
librarygatsby-starter-blog
with few examples of REPLsPromise.all
refactor