-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-source-mongodb): sanitize name correctly #11294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Thanks so much for the PR!
@DSchau thank you so much for the feedback! Working on it. |
@DSchau may you please review the changes? Thank You. |
@harshil1712 can you merge
then fix the conflict in Thanks so much! |
@DSchau I tried the steps. Please review it 😄 |
@DSchau the lodash library is being used. Please refer line 76 and 77 |
As suggested, since lodash is not being used, it is not required Co-Authored-By: harshil1712 <ghagrawal17@gmail.com>
@DSchau I have made the changes as you suggested. Please review it. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated and merged with master! Ready to merge!
Holy buckets, @harshil1712 — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
This is the PR for issue #11277. It fixes the sanitizeName error.
Related Issues
Related to #11277