feat(docs): Address some feedback on themes docs #12729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johno
commented
Mar 21, 2019
johno
commented
- Add naming conventions section
- Add layouts section for better theme composition
- Add naming conventions section - Add layouts section for better theme composition
ChristopherBiscardi
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
looks good to me
cc @dslemay Some of your feedback addressed here ^
johno
force-pushed
the
themes-docs-updates
branch
from
9207310 to
1dad80f
Compare
|
I appreciate the clarification and additional information. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.