Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Use new createContentDigest helper in gatsby-transformer-toml #12974

Conversation

charlyx
Copy link
Contributor

@charlyx charlyx commented Mar 31, 2019

Description

Hi again 👋

This PR makes use of the new createContentDigest helper in gatsby-transformer-toml.
I also have updated the related tests.

Related Issues

Related to #8805

@wardpeet
Copy link
Contributor

wardpeet commented Apr 1, 2019

@charlyx I updated your pr to fallback to crypto when it's people are still on an old gatsby as it is technically a breaking change.

@charlyx
Copy link
Contributor Author

charlyx commented Apr 1, 2019

Hi @wardpeet, thanks for your review!

I feel a bit concerned though.
Unless I'm wrong, that is not what has been done in other plugins...
Shall we add this fallback everywhere?

@wardpeet
Copy link
Contributor

wardpeet commented Apr 1, 2019

i'm waiting for @gatsbyjs/core to respond on this one as I'm unsure myself but I can't find any other createDigestContentin our code when I search in vscode 🙈 .

@wardpeet
Copy link
Contributor

wardpeet commented Apr 1, 2019

Rolling back my changes as we consider this not a breaking change and we have some warnings in place to let people know how to deal with this.

Thanks a bunch for your PR! 💪

@charlyx
Copy link
Contributor Author

charlyx commented Apr 1, 2019

@wardpeet Cool! I'll merge my PRs into one as suggested by @DSchau 😄
Thanks again for your review!

@charlyx
Copy link
Contributor Author

charlyx commented Apr 1, 2019

changes moved to #12973

@charlyx charlyx closed this Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants