Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starters): add gatsby-typescript-starter-default #14824

Merged
merged 4 commits into from
Jun 17, 2019

Conversation

RobertoMSousa
Copy link
Contributor

Description

There are no starters using eslint and prettier with typescript and since officially since the tslint will be deprecated it would be good for devs to start using eslint instead.

There are no starters using eslint and prettier with typescript and since officially since the tslint will be deprecated it would be good for devs to start using eslint instead.
@RobertoMSousa RobertoMSousa requested a review from a team June 16, 2019 14:59
Copy link
Contributor

@freiksenet freiksenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. Please add new entries to the end of file, not to the beginning. This simplifies diffs.

@RobertoMSousa
Copy link
Contributor Author

Thank you for this contribution. Please add new entries to the end of file, not to the beginning. This simplifies diffs.

Thanks for your review. Just did the required changes.

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks for creating a simple example with typescript

@wardpeet wardpeet merged commit e034605 into gatsbyjs:master Jun 17, 2019
@gatsbot
Copy link

gatsbot bot commented Jun 17, 2019

Holy buckets, @RobertoMSousa — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

mxxk pushed a commit to mxxk/gatsby that referenced this pull request Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants