Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-google-tagmanager): fix custom dataLayer name #16304

Merged
merged 1 commit into from
Aug 2, 2019
Merged

fix(gatsby-plugin-google-tagmanager): fix custom dataLayer name #16304

merged 1 commit into from
Aug 2, 2019

Conversation

chilic
Copy link
Contributor

@chilic chilic commented Aug 1, 2019

Description

This PR is fix regression for #12783
After #11379 was merged.

Affected code: https://github.com/gatsbyjs/gatsby/pull/11379/files#diff-858da3c14fa621fa9060ba6403b9d317L30

Related Issues

Related to #12782

@chilic chilic requested a review from a team as a code owner August 1, 2019 18:14
@chilic chilic changed the title feat(gatsby-plugin-google-tagmanager): Fix regression for Add plugin … fux(gatsby-plugin-google-tagmanager): regression for Add plugin … Aug 2, 2019
@chilic chilic changed the title fux(gatsby-plugin-google-tagmanager): regression for Add plugin … fix(gatsby-plugin-google-tagmanager): regression for Add plugin … Aug 2, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! 🎉 Thank you for fixing this. Code change looks :ok-hand:!

💜

@wardpeet wardpeet changed the title fix(gatsby-plugin-google-tagmanager): regression for Add plugin … fix(gatsby-plugin-google-tagmanager): fix custom dataLayer name Aug 2, 2019
@wardpeet wardpeet merged commit 6d097a5 into gatsbyjs:master Aug 2, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 2, 2019

Holy buckets, @chilic — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants