feat(gatsby-plugin-offline): "Magic" JS detection to make sites function correctly when JS is disabled retroactively #17590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 12, 2019 16:47
vtenfys
changed the title
|
Nice "magic" :-D |
pieh
reviewed
Sep 19, 2019
| @@ -15,9 +15,6 @@ export default function HTML(props) { | |||
| </head> | |||
| <body {...props.bodyAttributes}> | |||
| {props.preBodyComponents} | |||
| <noscript key="noscript" id="gatsby-noscript"> | |||
| This app works best with JavaScript enabled. | |||
| </noscript> | |||
There was a problem hiding this comment.
should this change be part of this PR?
There was a problem hiding this comment.
Also for reference - this is PR that added this initially #10945 so worth checking reasoning and see if we don't break that (or at least it's conscious decision)
vtenfys
added
bot: merge on green
LOLdevelopr
pushed a commit
to LOLdevelopr/gatsby-1
that referenced
this pull request
Sep 21, 2019
…ion correctly when JS is disabled retroactively (gatsbyjs#17590) * Set path resources on route update (for initial page load) * begin "magic" * refactor + fix always re-enabling * implement SW API route + only set head components for offline shell + misc * update snapshots * change messageapi back to a "normal" object * add comment re: syntax * rename back to original casing * add back noscript warning in default-html * restore snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gatsby-plugin-offline's service worker (which still runs if JavaScript has been disabled retroactively) can now detect via a conditional network request whether or not JavaScript has been disabled in the browser, and serve a page from the network if this is the case.Related Issues
Closes #17386