Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate CLI logic and depend on it in gatsby #1880

Merged
merged 4 commits into from
Aug 23, 2017
Merged

consolidate CLI logic and depend on it in gatsby #1880

merged 4 commits into from
Aug 23, 2017

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Aug 22, 2017

I think this is done, its a bit hard to test. wouldn’t say no to some more eyes on it :)

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit dc991d0

https://app.netlify.com/sites/using-glamor/deploys/599c97f30752d03e0da58547

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 22, 2017

Deploy preview failed.

Built with commit 2e82b02

https://app.netlify.com/sites/using-glamor/deploys/599e04607960b15febf434db

@KyleAMathews
Copy link
Contributor

On quick read through looks great! Love your refactors :-)

I'll test the PR manually in the morning to make sure nothing is broken.

Also looks like the yarn.lock got deleted.

@jquense
Copy link
Contributor Author

jquense commented Aug 23, 2017

oops on the yarn lock let me fix that

@KyleAMathews
Copy link
Contributor

Oooo and you fixed up gatsby new! Yeah that was super ugly looking. And very much like just letting the underlying tools log out normally so easier for people to debug problems.

@KyleAMathews
Copy link
Contributor

Only thing I saw missing was gatsby needed gatsby-cli as a dependency so added that. Other than than, things look great! Hopefully :-) big refactors like this are a bit hard to understand their implications so I guess let's be on our toes to fix any bugs that crop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants