Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and clarify Ghost sourcing page #19411

Merged
merged 2 commits into from
Nov 21, 2019
Merged

Fix and clarify Ghost sourcing page #19411

merged 2 commits into from
Nov 21, 2019

Conversation

dandv
Copy link
Contributor

@dandv dandv commented Nov 11, 2019

The Ghost sourcing page did not actually output any HTML. This PR fixes that, and attempts to clarify the process.

I still don't understand how postQuery is used. That symbol can be named whatever, and the posts are still rendered. Anyone?

It would also be useful to explain (or point to)

@dandv dandv requested a review from a team as a code owner November 11, 2019 04:27
@freiksenet
Copy link
Contributor

Thanks! Added a comment to clarify language.

@muescha
Copy link
Contributor

muescha commented Nov 17, 2019

postQuery

Name is not important. Only one per page. Gatsby just looks at the exports which is type graphql
see here: https://www.gatsbyjs.org/docs/page-query/#add-the-graphql-query

@jbampton jbampton added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Nov 19, 2019
@laurieontech
Copy link
Contributor

These changes look good to me. @dandv would you mind opening an issue with your larger questions so they don't get lost when this is merged? Thanks for helping out!

Co-Authored-By: Mikhail Novikov <freiksenet@gmail.com>
@laurieontech laurieontech merged commit f86d8c6 into master Nov 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the dandv-patch-1 branch November 21, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants