Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-subfont): Make async, add configurable option #21768

Merged
merged 10 commits into from
Mar 2, 2020
Merged

feat(gatsby-plugin-subfont): Make async, add configurable option #21768

merged 10 commits into from
Mar 2, 2020

Conversation

palindrom615
Copy link
Contributor

@palindrom615 palindrom615 commented Feb 26, 2020 •
edited by wardpeet
Loading

Description

Add gatsby-plugin-subfont configurable option feature
Update subfont version (Maybe issue #16840?)

Documentation

see: packages/gatsby-plugin-subfont/README.md

Related Issues

Related to #16840

@palindrom615 palindrom615 requested review from a team as code owners February 26, 2020 17:18
laurieontech
laurieontech reviewed Feb 26, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'll let core chime in on the technical aspects, but for the README I'd love to see explanations of what each option controls and what they default to.

@palindrom615
Copy link
Contributor Author

@laurieontech Thanks for the comment. I added an explanation for configurable options in README.

pvdz
pvdz suggested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides other comments, this changes the plugin from sync to async. I think that warrants a major bump, not a minor bump. But I'll discuss that to see what other people think.

packages/gatsby-plugin-subfont/src/gatsby-node.js Outdated Show resolved Hide resolved
packages/gatsby-plugin-subfont/src/gatsby-node.js Outdated Show resolved Hide resolved
packages/gatsby-plugin-subfont/src/gatsby-node.js Outdated Show resolved Hide resolved
@pvdz
Copy link
Contributor

pvdz commented Feb 27, 2020

Yeah please do a major rather than a minor bump

@palindrom615
Copy link
Contributor Author

I've just bumped up major version.

@pvdz pvdz changed the title feat(gatsby-plugin-subfont): add configurable option feat(gatsby-plugin-subfont): Make async, add configurable option Feb 27, 2020
laurieontech
laurieontech reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the README improvements! Looks all good from a learning perspective.

laurieontech
laurieontech previously approved these changes Feb 27, 2020
View reviewed changes
@wardpeet wardpeet self-assigned this Feb 29, 2020
wardpeet
wardpeet approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating! I'll publish when github is green

@wardpeet wardpeet merged commit 06034f2 into gatsbyjs:master Mar 2, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 2, 2020

Holy buckets, @palindrom615 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@wardpeet
Copy link
Contributor

wardpeet commented Mar 2, 2020

Published in gatsby-plugin-subfont@2.0.0

This was referenced Mar 17, 2020
Open
Open
This was referenced Oct 6, 2020
Open
Open
@ajesse11x ajesse11x mentioned this pull request Feb 23, 2021
Open
@saurabharch saurabharch mentioned this pull request Feb 23, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 19, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 29, 2022
Open
This was referenced Jul 21, 2022
Open
Open
@ajesse11x ajesse11x mentioned this pull request Aug 24, 2022
Open
@saurabharch saurabharch mentioned this pull request Nov 27, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Apr 16, 2024
Open
@saurabharch saurabharch mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz requested changes

@wardpeet wardpeet wardpeet approved these changes

@laurieontech laurieontech laurieontech left review comments

Assignees

@wardpeet wardpeet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palindrom615 @pvdz @wardpeet @laurieontech