chore(gatsby-core-utils): port physical cpu count to ts #22031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Mar 9, 2020
| @@ -52,4 +52,4 @@ function getPhysicalCpuCount() { | |||
| return fallbackToNodeJSCheck() | |||
| } | |||
|
|
|||
| module.exports = getPhysicalCpuCount() | |||
| export default getPhysicalCpuCount() | |||
There was a problem hiding this comment.
Let's use Guidelines (from #21995 description):
Only use named exports, no export default.
Suggested change
| export default getPhysicalCpuCount() | |
| export const physicalCpuCount = getPhysicalCpuCount() |
and adjust all physical-cpu-count imports?
That should be in
and various tests
|
Sorry, I hijacked this change in #22122 Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
port physical-cpu-count.js to typescript
Related Issues
Related to #21995