Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): migrate error component to typescript #22098

Merged
merged 2 commits into from
Mar 11, 2020
Merged

chore(cli): migrate error component to typescript #22098

merged 2 commits into from
Mar 11, 2020

Conversation

Naturalclar
Copy link
Contributor

Description

Migrated Error component in the cli to typescript

Documentation

Related Issues

#21995

@Naturalclar Naturalclar requested a review from a team as a code owner March 9, 2020 15:57
@blainekasten blainekasten mentioned this pull request Mar 9, 2020
Closed
@Naturalclar Naturalclar changed the title cli: migrate error component to typescript chore(cli): migrate error component to typescript Mar 9, 2020
blainekasten
blainekasten previously approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: TypeScript migration labels Mar 9, 2020
@Naturalclar
Copy link
Contributor Author

Thanks for the review! Changed the Component Type to FunctionComponent

@blainekasten blainekasten merged commit 5fcfc93 into master Mar 11, 2020
@blainekasten blainekasten deleted the error/typescript branch March 11, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cola119 cola119 cola119 left review comments

@MichaelDeBoey MichaelDeBoey MichaelDeBoey requested changes

@ascorbic ascorbic ascorbic requested changes

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Naturalclar @ascorbic @blainekasten @MichaelDeBoey @cola119