Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-typescript): use TS parser for ts files and replace some vanilla js rules with typescript ones #22330

Closed
wants to merge 2 commits into from

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Mar 16, 2020

This makes sure we use TS parser for .ts(x) files in built-in linting with webpack. I also adjust few rules from vanilla js to typescript ones (like no-unused-vars is needed because vanilla js will show warnings for type only imports)

Fixes #21913

@pieh pieh requested a review from a team as a code owner March 16, 2020 12:04
@blainekasten
Copy link
Contributor

This code looks good but for some reason I'm not really able to get my local set up to test these changes so I can't be confident to approve.

@pieh
Copy link
Contributor Author

pieh commented Mar 16, 2020

Ok, so babel-preset-react-app does have overrides for .ts(x)? files. So my changes are somehow working around other issues (apparently in eslint or in our config). This is wrong fix, so I'll close it

@pieh pieh closed this Mar 16, 2020
@pieh pieh deleted the ts-use-ts-parser branch March 18, 2020 13:37
@pieh pieh restored the ts-use-ts-parser branch May 17, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(gatsby-plugin-typescript): linting causes errors
2 participants