Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: chore(gatsby): migrate webpack utils to TypeScript #22381

Merged
merged 15 commits into from
Mar 20, 2020
Merged

[WIP]: chore(gatsby): migrate webpack utils to TypeScript #22381

merged 15 commits into from
Mar 20, 2020

Conversation

sasurau4
Copy link
Contributor

Description

Part of #21995

I migrated webpack-utils.js to TypeScript

Documentation

Related Issues

#21995

@sasurau4 sasurau4 requested a review from a team as a code owner March 18, 2020 15:33
@blainekasten blainekasten mentioned this pull request Mar 18, 2020
Closed
blainekasten
blainekasten reviewed Mar 19, 2020
View reviewed changes
packages/gatsby/src/utils/webpack-plugins.ts
const plugin = (
name: string,
optimize?: boolean
): ((...args: any) => Plugin) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha good catch. Thanks for fixing!

@blainekasten
Copy link
Contributor

There is a large amount of any types in this file. Would it be possible to improve those types?

@sasurau4
Copy link
Contributor Author

@blainekasten I'll try to reduce any as much as possible. 👍
Some other files need to migrate, so I'll try to migrate them at first.

@sasurau4 sasurau4 changed the title chore(gatsby): migrate webpack utils to TypeScript [WIP]: chore(gatsby): migrate webpack utils to TypeScript Mar 19, 2020
@sasurau4 sasurau4 requested a review from a team as a code owner March 20, 2020 14:34
@blainekasten blainekasten merged commit 9d5371a into gatsbyjs:master Mar 20, 2020
@sasurau4 sasurau4 deleted the migrate/webpack-utils branch March 20, 2020 17:18
@gillkyle gillkyle mentioned this pull request Mar 20, 2020
Merged
@muescha muescha mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sasurau4 @blainekasten @wardpeet