chore(gatsby): convert jobs to typescript #24209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pvdz
removed
the
status: triage needed
pvdz
suggested changes
May 19, 2020
| @@ -29,16 +30,15 @@ describe(`Job actions/reducer`, () => { | |||
| }) | |||
|
|
|||
| it(`throws an error if an ID isn't provided`, done => { | |||
| function runReducer() { | |||
There was a problem hiding this comment.
Can you please undo the function->arrow changes? (Also below) Or explain why you're doing them?
There was a problem hiding this comment.
Since the this keyword is not used, I thought about removing them.
You are correct that there is no benefit to this change, I'm removing them 👍 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
src/redux/reducers/jobs.tsand relative test file to TypeScript.Related Issues
#21995