Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Migrate reducers/nodes-touched to TypeScript #24247

Merged
merged 2 commits into from
May 20, 2020
Merged

chore(gatsby): Migrate reducers/nodes-touched to TypeScript #24247

merged 2 commits into from
May 20, 2020

Conversation

carrotderek
Copy link
Contributor

Description

This PR converts packages\gatsby\src\redux\reducers\nodes-touched.js and related files to TypeScript.

Related Issues

Related to #21995

@carrotderek carrotderek requested a review from a team as a code owner May 20, 2020 03:35
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 20, 2020
@blainekasten blainekasten mentioned this pull request May 20, 2020
Closed
@vladar vladar added type: TypeScript migration and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 20, 2020
vladar
vladar reviewed May 20, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this. Github posted this review to the wrong PR.

vladar
vladar approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 💜

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label May 20, 2020
@gatsbybot gatsbybot merged commit 1607f1d into gatsbyjs:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carrotderek @vladar @gatsbybot