fix(gatsby-plugin-google-tagmanager): Add "aria-hidden" #27062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: plugins-analytics
LekoArts
changed the title
|
Thanks for the PR! You'll need to update the snapshot tests to get CI passing :) |
Good callout. Updated. |
mareksuscak
force-pushed
the
accessible-tag-manager
branch
from
1993d24 to
03c3956
Compare
mareksuscak
force-pushed
the
accessible-tag-manager
branch
from
03c3956 to
0f13a80
Compare
|
@LekoArts this PR is now ready to be merged at your earliest convenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the official Google Tag Manager plugin WCAG compliant. Various tools are pointing out that
iframewithout atitleattribute violates the accessibility requirements. However, it doesn't make sense to include a title because Google Tag Manager's iframe is used in headless mode. So I'm addingaria-hidden="true"instead.This was verified by running an audit using SortSite.
Before:
After:
Resources:
Documentation
Related Issues