Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(gatsby): Warn when there's unknown flags in gatsby-config.js & suggest fixes to potential typos #28326

Merged
merged 4 commits into from
Nov 28, 2020

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Nov 27, 2020

DX-baby

Screen Shot 2020-11-27 at 10 19 15 AM

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 27, 2020
@KyleAMathews KyleAMathews added type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 27, 2020
@pieh pieh self-assigned this Nov 27, 2020
pieh
pieh previously approved these changes Nov 27, 2020
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few non-blocking comments - feel free to either address or merge ;)

packages/gatsby/src/utils/handle-flags.ts Outdated Show resolved Hide resolved
packages/gatsby/src/utils/handle-flags.ts Outdated Show resolved Hide resolved
@pieh pieh added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 28, 2020
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@gatsbybot gatsbybot merged commit c4978e9 into master Nov 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the warn-unknown-flags branch November 28, 2020 10:02
pieh pushed a commit that referenced this pull request Nov 30, 2020
…& suggest fixes to potential typos (#28326)

* feature(gatsby): Warn when there's unknown flags in gatsby-config.js & suggest fixes to potential typos

* Update packages/gatsby/src/utils/handle-flags.ts

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>

* Reformat message per @pieh's suggestion

* make typescript happy

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
(cherry picked from commit c4978e9)
pieh added a commit that referenced this pull request Dec 1, 2020
…& suggest fixes to potential typos (#28326) (#28382)

* feature(gatsby): Warn when there's unknown flags in gatsby-config.js & suggest fixes to potential typos

* Update packages/gatsby/src/utils/handle-flags.ts

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>

* Reformat message per @pieh's suggestion

* make typescript happy

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
(cherry picked from commit c4978e9)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants