-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(gatsby): Warn when there's unknown flags in gatsby-config.js & suggest fixes to potential typos #28326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…& suggest fixes to potential typos
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Nov 27, 2020
KyleAMathews
added
type: feature or enhancement
Issue that is not a bug and requests the addition of a new feature or enhancement.
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Nov 27, 2020
pieh
previously approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left few non-blocking comments - feel free to either address or merge ;)
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
pieh
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
Nov 28, 2020
pieh
approved these changes
Nov 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
pieh
pushed a commit
that referenced
this pull request
Nov 30, 2020
…& suggest fixes to potential typos (#28326) * feature(gatsby): Warn when there's unknown flags in gatsby-config.js & suggest fixes to potential typos * Update packages/gatsby/src/utils/handle-flags.ts Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> * Reformat message per @pieh's suggestion * make typescript happy Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> (cherry picked from commit c4978e9)
pieh
added a commit
that referenced
this pull request
Dec 1, 2020
…& suggest fixes to potential typos (#28326) (#28382) * feature(gatsby): Warn when there's unknown flags in gatsby-config.js & suggest fixes to potential typos * Update packages/gatsby/src/utils/handle-flags.ts Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> * Reformat message per @pieh's suggestion * make typescript happy Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> (cherry picked from commit c4978e9) Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
type: feature or enhancement
Issue that is not a bug and requests the addition of a new feature or enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DX-baby