Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-image): don't show hydration warning #28407

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Dec 1, 2020

Description

Fixes warning on development "expected server HTML to contain a matching <img> in <div>".

On develop or client side navigation we want to go forward with React.render instead of hydrate because there is nothing to hydrate from.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 1, 2020
ascorbic
ascorbic previously approved these changes Dec 1, 2020
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks!

@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 1, 2020
@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 3, 2020
@gatsbybot gatsbybot merged commit b6b5207 into gatsbyjs:master Dec 3, 2020
pieh pushed a commit that referenced this pull request Dec 7, 2020
Co-authored-by: Matt Kane <matt@gatsbyjs.com>
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit b6b5207)
pieh pushed a commit that referenced this pull request Dec 7, 2020
Co-authored-by: Matt Kane <matt@gatsbyjs.com>
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit b6b5207)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
@pieh
Copy link
Contributor

pieh commented Dec 7, 2020

Published in gatsby-plugin-image@0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants