Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-mdx): Add root to plugin validation #29010

Merged
merged 2 commits into from
Jan 18, 2021
Merged

fix(gatsby-plugin-mdx): Add root to plugin validation #29010

merged 2 commits into from
Jan 18, 2021

Conversation

LekoArts
Copy link
Contributor

Description

Some users use root option and a warning is thrown for that. I couldn't really find what it does, so please comment if you know

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 13, 2021
@LekoArts LekoArts added topic: MDX and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 13, 2021
pvdz
pvdz previously approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

It is an actual option so let's merge it anyways.

@pieh pieh merged commit 3163ca6 into master Jan 18, 2021
@pieh pieh deleted the mdx-plugin-validation branch January 18, 2021 13:25
This was referenced Jan 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 1, 2024
Open
Open
This was referenced Jan 1, 2024
Open
Open
Open
@wizbit wizbit mentioned this pull request Jan 2, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Jan 2, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 2, 2024
Open
@impactyogi impactyogi mentioned this pull request Jan 2, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 2, 2024
Open
@joeawillis joeawillis mentioned this pull request Jan 2, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Mar 15, 2024
Open
@joeawillis joeawillis mentioned this pull request Mar 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Mar 15, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Mar 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Mar 15, 2024
Open
This was referenced Mar 15, 2024
Open
Open
Open
@monizb monizb mentioned this pull request Mar 16, 2024
Open
This was referenced Mar 16, 2024
Open
Open
Open
@joeawillis joeawillis mentioned this pull request Mar 16, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Mar 16, 2024
Open
@joeawillis joeawillis mentioned this pull request Mar 18, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 22, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

@pvdz pvdz pvdz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LekoArts @pvdz @pieh