Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-typescript): add missing options validations #29066

Merged
merged 3 commits into from
Jan 18, 2021
Merged

fix(gatsby-plugin-typescript): add missing options validations #29066

merged 3 commits into from
Jan 18, 2021

Conversation

hasparus
Copy link
Contributor

Description

Added missing field validations, as all options are passed to @babel//preset-typescript.

Documentation

I'm not sure if the docs need to be updated. They already link to Babel docs.
https://www.gatsbyjs.com/plugins/gatsby-plugin-typescript/

Related Issues

Closes #29063

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 18, 2021
@hasparus
Copy link
Contributor Author

image

I'm not sure how to fix this.

@hasparus
Copy link
Contributor Author

image

This isn't connected to my PR, right?

@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 18, 2021
LekoArts
LekoArts approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will be released together with 2.31 (so tomorrow)

@LekoArts LekoArts merged commit c0e6c92 into gatsbyjs:master Jan 18, 2021
@hasparus
Copy link
Contributor Author

Thanks, LekoArts!

This was referenced Jan 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 1, 2024
Open
Open
This was referenced Jan 1, 2024
Open
Open
Open
@wizbit wizbit mentioned this pull request Jan 2, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Jan 2, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 2, 2024
Open
@impactyogi impactyogi mentioned this pull request Jan 2, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 2, 2024
Open
@joeawillis joeawillis mentioned this pull request Jan 2, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Mar 15, 2024
Open
@joeawillis joeawillis mentioned this pull request Mar 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Mar 15, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Mar 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Mar 15, 2024
Open
This was referenced Mar 15, 2024
Open
Open
Open
@monizb monizb mentioned this pull request Mar 16, 2024
Open
This was referenced Mar 16, 2024
Open
Open
Open
@joeawillis joeawillis mentioned this pull request Mar 16, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Mar 16, 2024
Open
@joeawillis joeawillis mentioned this pull request Mar 18, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 22, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-typescript]: options schema is missing a few options
2 participants
@hasparus @LekoArts