Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): Sanitize tmp filename #29246

Merged
merged 1 commit into from
Jan 28, 2021
Merged

fix(gatsby-plugin-sharp): Sanitize tmp filename #29246

merged 1 commit into from
Jan 28, 2021

Conversation

ascorbic
Copy link
Contributor

Ensures that the generated filename is valid. It was breaking on WIndows as the digest included colons.

Fixes #29071

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 28, 2021
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 28, 2021
vladar
vladar approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've seen this error recently! Thanks for fixing it!

@ascorbic ascorbic merged commit c0f1b5c into master Jan 28, 2021
@ascorbic ascorbic deleted the fix/svg-tmpname branch January 28, 2021 15:47
This was referenced Mar 13, 2021
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Jul 21, 2021
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-source-contentful] tracedSVG error on windows
2 participants
@ascorbic @vladar