Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure to pass the failOnError option to base64 generation #29254

Conversation

domvo
Copy link
Contributor

@domvo domvo commented Jan 28, 2021

Description

The gatsby-image-sharp plugin accepts (among others) a failOnError option. This option is not passed down properly during the creation of Base64 images. So if you send a "corrupted" file to it, it will fail, causing the whole build to fail.

Documentation

Related Issues

Addresses #28203

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 28, 2021
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I've left one change request.

packages/gatsby-plugin-sharp/src/index.js Outdated Show resolved Hide resolved
@vladar vladar added topic: sharp and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 29, 2021
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
@domvo
Copy link
Contributor Author

domvo commented Jan 29, 2021

Thanks! Change is commited!

Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@vladar vladar merged commit bc0f5c8 into gatsbyjs:master Jan 29, 2021
ascorbic pushed a commit that referenced this pull request Feb 1, 2021
… base64 generation (#29254)

* make sure to pass the failOnError option to base64 generation

* Update packages/gatsby-plugin-sharp/src/index.js

Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>

Co-authored-by: Dominik Voss <dominik.voss@check24.de>
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
(cherry picked from commit bc0f5c8)
ascorbic added a commit that referenced this pull request Feb 1, 2021
… base64 generation (#29254) (#29290)

* make sure to pass the failOnError option to base64 generation

* Update packages/gatsby-plugin-sharp/src/index.js

Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>

Co-authored-by: Dominik Voss <dominik.voss@check24.de>
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
(cherry picked from commit bc0f5c8)

Co-authored-by: Dom <dominikvoss@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants