-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade typescript #29388
Merged
Merged
chore: Upgrade typescript #29388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Feb 8, 2021
ascorbic
force-pushed
the
chore/upgrade-typescript
branch
from
February 8, 2021 13:19
cb40e9a
to
fa8203a
Compare
ascorbic
added
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Feb 8, 2021
ascorbic
force-pushed
the
chore/upgrade-typescript
branch
from
February 23, 2021 09:36
70d985a
to
e775ec9
Compare
wardpeet
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade TypeScript, and make a few changes to types to be compatible. I've also removed a
String.prototype.matchAll
polyfill that we don't need now we've dropped Node 10 support, as it deleted fields that are required in the built-in Regexp typings. Upgraded typescript-eslint, and then fix all the errors that it had somehow missed before.