Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Update headless WordPress article #29402

Merged
merged 6 commits into from
Mar 1, 2021
Merged

chore(docs): Update headless WordPress article #29402

merged 6 commits into from
Mar 1, 2021

Conversation

hashimwarren
Copy link
Contributor

I updated the "headless WordPress" definition to provide more clarity. I also changed the related links to reflect the new WordPress source plugin

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 9, 2021
@hashimwarren hashimwarren added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 9, 2021
@hashimwarren hashimwarren added the topic: source-wordpress Related to Gatsby's integration with WordPress label Feb 9, 2021
meganesu
meganesu suggested changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@meganesu meganesu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change! I left a few notes with copy edits, but other than that I think this looks good.

It looks like this is failing the lint step, so that will need to be fixed too.

docs/docs/glossary/headless-wordpress.md Outdated Show resolved Hide resolved
docs/docs/glossary/headless-wordpress.md Outdated Show resolved Hide resolved
docs/docs/glossary/headless-wordpress.md Outdated Show resolved Hide resolved
hashimwarren and others added 5 commits February 24, 2021 13:44
@hashimwarren @meganesu
Update docs/docs/glossary/headless-wordpress.md
5c895d4 
Co-authored-by: Megan Sullivan <megan@gatsbyjs.com>
@hashimwarren @meganesu
Update docs/docs/glossary/headless-wordpress.md
4c62083 
Co-authored-by: Megan Sullivan <megan@gatsbyjs.com>
@hashimwarren @meganesu
Update docs/docs/glossary/headless-wordpress.md
bb416dc 
Co-authored-by: Megan Sullivan <megan@gatsbyjs.com>
Merge remote-tracking branch 'upstream/master' into headless-wordpres…
5774abb 
…s-update
chore: format
16dc354
@hashimwarren
Copy link
Contributor Author

thanks for the review. I ran the linter and now all tests are green ✅

@LekoArts LekoArts changed the title (docs) Update headless wordpress article chore(docs): Update headless WordPress article Mar 1, 2021
@LekoArts LekoArts merged commit 44f5e2d into master Mar 1, 2021
@LekoArts LekoArts deleted the headless-wordpress-update branch March 1, 2021 14:39
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot @meganesu
chore(docs): Update headless WordPress article (gatsbyjs#29402)
70858f5 
Co-authored-by: Megan Sullivan <megan@gatsbyjs.com>
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

@meganesu meganesu Awaiting requested review from meganesu

Assignees

@meganesu meganesu

Labels
topic: source-wordpress Related to Gatsby's integration with WordPress type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hashimwarren @meganesu @LekoArts