Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop terminal-link (#29472) #29477

Merged
merged 1 commit into from
Feb 12, 2021
Merged

fix: drop terminal-link (#29472) #29477

merged 1 commit into from
Feb 12, 2021

Conversation

ascorbic
Copy link
Contributor

Backporting #29472 to the 2.32 release branch

(cherry picked from commit 260c297)

There is weird interaction in some terminals with our usage of terminal-link and ink where following lines turn blank.
Let's just remove our usage of terminal-link as value it provides is not worth spending a lot of time on figuring exact reason for this.

(cherry picked from commit 260c297)
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 12, 2021
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 12, 2021
@pieh pieh merged commit 6374419 into release/2.32 Feb 12, 2021
@pieh pieh deleted the backport-2.32-29472 branch February 12, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants